Remove the #include <setjmp.h> from _CStdlib.h
#873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like we don't use neither setjmp nor longjmp in the Foundation codebase, so we can safely remove this include. The main motivation for this change is to fix the build with the latest wasi-libc version. Recent wasi-libc versions started to provide `setjmp.h` header but it raises compilation errors unless Exception Handling feature (still under standardization process) is enabled. See https://github.com/WebAssembly/wasi-libc/blob/wasi-sdk-22/libc-top-half/musl/include/setjmp.h
|
@swift-ci test |
jmschonfeld
approved these changes
Aug 19, 2024
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
It seems like we don't use neither setjmp nor longjmp in the Foundation codebase, so we can safely remove this include. The main motivation for this change is to fix the build with the latest wasi-libc version. Recent wasi-libc versions started to provide `setjmp.h` header but it raises compilation errors unless Exception Handling feature (still under standardization process) is enabled. See https://github.com/WebAssembly/wasi-libc/blob/wasi-sdk-22/libc-top-half/musl/include/setjmp.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like we don't use neither setjmp nor longjmp in the Foundation codebase, so we can safely remove this include.
The main motivation for this change is to fix the build with the latest wasi-libc version. Recent wasi-libc versions started to provide
setjmp.hheader but it raises compilation errors unless Exception Handling feature (still under standardization process) is enabled.See https://github.com/WebAssembly/wasi-libc/blob/wasi-sdk-22/libc-top-half/musl/include/setjmp.h