Fix Windows home directory for specific user #861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
compnerd
approved these changes
Aug 16, 2024
|
Hmm, it looks like |
|
@swift-ci please test |
itingliu
approved these changes
Aug 16, 2024
jmschonfeld
added a commit
to jmschonfeld/swift-foundation
that referenced
this pull request
Aug 16, 2024
* Fix Windows home directory for specific user * Fix test failure
jmschonfeld
added a commit
that referenced
this pull request
Aug 19, 2024
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
* Fix Windows home directory for specific user * Fix test failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking up a home directory for a specific user, we currently have a bug that results in always using the fallback path. This PR updates the implementation to:
LookupAccountNameWandRegGetValueWto fail at the first call with an empty buffer (since there is no space in the buffer and it needs to return a valid buffer size\(String(decodingC...text into the key stringThe added unit test ensures we exercise this code path