FileManager.fileExists(atPath:) should follow symlinks on Windows #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
This PR depends on changes from #858, I'll wait until that is merged and then rebase and re-run tests |
compnerd
approved these changes
Aug 16, 2024
itingliu
approved these changes
Aug 16, 2024
jmschonfeld
force-pushed
the
windows/file-exists-follow-symlinks
branch
from
0302cd5 to
699469b
Compare
|
@swift-ci please test |
jmschonfeld
added a commit
to jmschonfeld/swift-foundation
that referenced
this pull request
Aug 16, 2024
jmschonfeld
added a commit
that referenced
this pull request
Aug 19, 2024
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a followup to #858, I've also noticed that
FileManager.fileExists(atPath:)does not correctly handle symlinks on Windows. On Darwin/Linux this function determines if the destination of the symlink exists, but on Windows it currently checks whether the symlink itself exists. This updates the logic to follow the symlink and check the destination instead to match previous (swift 5.10) Windows behavior (and behavior on Darwin/Linux)