[wasm] Fall back to a default chunk size when st_blksize is not available
#835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
MaxDesiatov
approved these changes
Aug 8, 2024
MaxDesiatov
reviewed
Aug 8, 2024
…ilable The `st_blksize` field in `stat` struct is not provided by WASI, so we fall back to a default chunk size 4KB, which is a common page size.
kateinoigakukun
force-pushed
the
pr-fe104281f01ec42724d1bbf81bb7c870ff6b477b
branch
from
bb01d84 to
abd2b40
Compare
|
@swift-ci test |
33 tasks
jmschonfeld
approved these changes
Aug 8, 2024
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
…ilable (swiftlang#835) The `st_blksize` field in `stat` struct is not provided by WASI, so we fall back to a default chunk size 4KB, which is a common page size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
st_blksizefield instatstruct is not provided by WASI, so we fall back to a default chunk size 4KB, which is a common page size. Otherwise, the belowreadandwriteloop won't progress.