Add JSON benchmarks and make benchmark package build for more targets #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
jmschonfeld
reviewed
Aug 2, 2024
Benchmarks/Package.swift
Outdated
|
|
||
| case .useGitHubPackage: | ||
| #if os(macOS) | ||
| packageDependency.append(.package(url: "https://github.com/apple/swift-foundation", revision: "8a44479120e4ae0ac8cdbf801943daa0d1e874ad")) |
There was a problem hiding this comment.
Should we have this depend on the main branch rather than a particular hash?
| @@ -67,6 +67,8 @@ func registerPredicateTests_disabled() { | |||
| #endif | |||
|
|
|||
| func registerPredicateTests() { | |||
| // Temporarily disabled due to link issue | |||
| #if FOUNDATION_FRAMEWORK | |||
There was a problem hiding this comment.
Should this be #if USE_PACKAGE || os(macOS) (the link issue was only present in non-Darwin toolchains).
FWIW, the link issue should now be resolved, but the macro doesn't exist in a Windows toolchain yet so eventually this will have to be #if USE_PACKAGE || !os(Windows)
glessard
reviewed
Aug 2, 2024
| let twitter = try! _JSONDecoder().decode(TwitterArchive.self, from: twitterData) | ||
|
|
||
| Benchmark("Canada-decodeFromJSON") { benchmark in | ||
| let result = try! _JSONDecoder().decode(FeatureCollection.self, from: canadaData) |
There was a problem hiding this comment.
The closure passed to the Benchmark initializer can throw, so we can just use try here. (The benchmarks closure however cannot throw, sadly.)
glessard
approved these changes
Aug 2, 2024
|
@swift-ci test |
jmschonfeld
approved these changes
Aug 2, 2024
glessard
approved these changes
Aug 2, 2024
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
…swiftlang#810) * Add JSON benchmarks and make benchmark package build for more targets * Address review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some JSON benchmarks to the suite, and also makes the benchmarks build for these configs:
Linux, Swift 5.10 (toolchain)
Linux, Swift 6.0 (toolchain)
Linux, Swift 6.0 (package, or local checkout)
macOS (system Foundation.framework)
macOS (package, or local checkout)