Skip to content

Fix benchmark running from the command line #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

glessard
Copy link
Contributor

@glessard glessard commented Jul 26, 2024

This fixes a number of issues for the swift-foundation benchmarks.

  • Use URL-based file APIs for portability
  • Tolerate autoreleasepool blocks when the Obj-C runtime isn't present
  • Work around declaration ambiguity of String.Encoding when another import of Foundation inevitably exists.

With this, swift package benchmark works when issued within the Benchmarks subdirectory.

@glessard glessard requested a review from iCharlesHu July 26, 2024 22:44
@glessard
Copy link
Contributor Author

@swift-ci please test

glessard added 2 commits July 29, 2024 17:07
- also fixes issue with `autoreleasepool()`
@glessard
Copy link
Contributor Author

@swift-ci please test

@glessard glessard changed the title Benchmark Tweaks Fix benchmark running from the command line Jul 30, 2024
@glessard glessard marked this pull request as ready for review July 30, 2024 23:36
@glessard
Copy link
Contributor Author

glessard commented Aug 9, 2024

Closing in favor of #810

@glessard glessard closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants