[Windows] Implement additional file attributes #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
parkera
approved these changes
Jul 12, 2024
compnerd
reviewed
Jul 12, 2024
Sources/FoundationEssentials/FileManager/FileManager+Files.swift
Outdated
Show resolved
Hide resolved
| let systemFileNumber = UInt64(info.nFileIndexHigh << 32) | UInt64(info.nFileIndexLow) | ||
| let referenceCount = UInt64(info.nNumberOfLinks) | ||
|
|
||
| let isReadOnly = info.dwFileAttributes & FILE_ATTRIBUTE_READONLY != 0 |
There was a problem hiding this comment.
I think that it is safer to ensure that the bit is set ...
Suggested change
| let isReadOnly = info.dwFileAttributes & FILE_ATTRIBUTE_READONLY != 0 | |
| let isReadOnly = info.dwFileAttributes & FILE_ATTRIBUTE_READONLY == FILE_ATTRIBUTE_READONLY |
There was a problem hiding this comment.
Personally I prefer the != 0 version. If we're doing a bitwise AND, we know the answer is either 0 or FILE_ATTRIBUTE_READONLY. The only way we could trip up is if FILE_ATTRIBUTE_READONLY is not really a bit mask, but that would be wrong for either formulation (and we already know it's a bit mask anyway).
Sources/FoundationEssentials/FileManager/FileManager+Files.swift
Outdated
Show resolved
Hide resolved
Sources/FoundationEssentials/FileManager/FileManager+Files.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Saleem Abdulrasool <compnerd@compnerd.org>
compnerd
reviewed
Jul 12, 2024
Sources/FoundationEssentials/FileManager/FileManager+Files.swift
Outdated
Show resolved
Hide resolved
compnerd
reviewed
Jul 12, 2024
|
@swift-ci please test |
al45tair
approved these changes
Jul 12, 2024
compnerd
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the remaining attributes for
attributesOfItem(atPath:)for windows. This is required for the Windows toolchain build becauseTSCBasicrequires these attributes andswiftc.exeends up calling down to this API while compiling SwiftPM manifests.The implementation of all of these attributes comes from the existing sources in swift-corelibs-foundation (roughly).