Improve performance of FormatStyle formatting when used in multithreaded context #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
parkera
commented
Jul 5, 2024
| } | ||
| // MARK: Singletons | ||
|
|
||
| static let autoupdatingCurrent = _CalendarAutoupdating() |
There was a problem hiding this comment.
For example - this does not need to be stored in the cache, which requires accessing the lock in order to get it.
parkera
commented
Jul 5, 2024
| internal import Synchronization | ||
| #endif | ||
|
|
||
| /// Keeps a global generation count for updated Locale information, including locale, time zone, and calendar preferences. |
There was a problem hiding this comment.
This new type stores the info about when we need to reset caches, due to system changes.
parkera
commented
Jul 5, 2024
Sources/FoundationInternationalization/Formatting/Number/ICUNumberFormatter.swift
Show resolved
Hide resolved
|
@swift-ci test |
|
It seems the macOS failure is relevant? |
itingliu
reviewed
Jul 8, 2024
Sources/FoundationInternationalization/Formatting/Number/ICUNumberFormatter.swift
Show resolved
Hide resolved
| return calendar | ||
| var calendar = Calendar(identifier: calendarIdentifier) | ||
|
|
||
| if let prefs { |
There was a problem hiding this comment.
hm... previously we always access prefs inside the lock, but not anymore. I can see that this would indeed help speeding it up
| } | ||
| static let cache = CalendarCache() | ||
|
|
||
| // The values stored in these two locks do not depend upon each other, so it is safe to access them with separate locks. This helps avoids contention on a single lock. |
| CalendarCache.cache.reset() | ||
| #if FOUNDATION_FRAMEWORK | ||
| if let oldDefaultTimeZone { | ||
| let noteName = CFNotificationName(rawValue: "kCFTimeZoneSystemTimeZoneDidChangeNotification-2" as CFString) |
There was a problem hiding this comment.
itingliu
reviewed
Jul 8, 2024
|
@swift-ci please test |
itingliu
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the performance of formatting dates and times, especially when used in multithreaded contexts.
This patch reworks some of the caching in the Locale, TimeZone, and Calendar types to more efficiently store the singleton values.
Before
After