Skip to content

Refactoring some import conditions #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

iCharlesHu
Copy link
Contributor

No description provided.

@iCharlesHu
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@Catfish-Man Catfish-Man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@iCharlesHu iCharlesHu changed the title Refactoring for ExclaveKit Refactoring some import conditions Oct 20, 2023
@jmschonfeld
Copy link
Contributor

Looks like there are some build failures here about usages of NSLocale in places not guarded by FOUNDATION_FRAMEWORK

@iCharlesHu
Copy link
Contributor Author

@swift-ci please test

@iCharlesHu
Copy link
Contributor Author

Fixed the build and test failure (hopefully)

@iCharlesHu
Copy link
Contributor Author

Linux failure is fixed in swiftlang/swift-syntax#2312
Hopefully we'll get a new snapshot soon

@iCharlesHu iCharlesHu merged commit 7272a47 into swiftlang:main Oct 25, 2023
@iCharlesHu iCharlesHu deleted the charles/exclavekit branch October 25, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants