improve CustomNSError.errorDomain calculation #1032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisBenua
force-pushed
the
ChrisBenua/improve-CustomNSError-domain-calculation
branch
from
94f174e to
b4e1622
Compare
|
@swift-ci please test |
parkera
approved these changes
Nov 4, 2024
jmschonfeld
approved these changes
Nov 4, 2024
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized
CustomNSError.errorDomaincalculation.String(reflecting:)forAny.Typeobjects eventually calls_type(:qualified:). ButString(reflecting:)call has overhead because ofas?checks.All details are listed in issue.
Also I've opened same MR for non-Darwin platforms: swiftlang/swift-corelibs-foundation#5132