Skip to content

Revert "Fix JSONEncoder performance regression in 6.0 toolchain" #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hjyamauchi
Copy link

Reverts #1006

@hjyamauchi
Copy link
Author

@swift-ci please test

@hjyamauchi
Copy link
Author

Hi @kperryua :) I think you're probably looking into this, but it appears that the CI https://ci-external.swift.org/job/swift-PR-windows is broken at #1006 and blocking the PRs. This temporary PR seems to how that the CI passes with a revert. What do you think of reverting it? Thank you

For example,
https://ci-external.swift.org/job/swift-PR-windows/32609/consoleText
https://ci-external.swift.org/job/swift-PR-windows/32610/consoleText
https://ci-external.swift.org/job/swift-PR-windows/32612/consoleText

TestJSonEncoder failures:

TestFoundation/TestJSONEncoder.swift:1064: error: TestJSONEncoder.test_encodingDateCustom : XCTAssertEqual failed: ("JSON(jsonObject: [42])") is not equal to ("JSON(jsonObject: [[:]])") - Produced JSON not identical to expected JSON.

TestFoundation/TestJSONEncoder.swift:1064: error: TestJSONEncoder.test_encodingDateFormatted : XCTAssertEqual failed: ("JSON(jsonObject: ["Thursday, 1 January 1970 at 12:16:40 AM Greenwich Mean Time"])") is not equal to ("JSON(jsonObject: [[:]])") - Produced JSON not identical to expected JSON.

TestFoundation/TestJSONEncoder.swift:1075: error: TestJSONEncoder.test_encodingDateFormatted : failed - Failed to decode (TopLevelArrayWrapper in _845CC7E595F11E7F77C76EC5CBA6E9D7)<Date> from JSON: typeMismatch(Swift.String, Swift.DecodingError.Context(codingPath: [_CodingKey(stringValue: "Index 0", intValue: 0)], debugDescription: "Expected to decode String but found a dictionary instead.", underlyingError: nil))
...

@kperryua
Copy link
Contributor

kperryua commented Oct 25, 2024

It's already reverted on main, thanks!

@hjyamauchi
Copy link
Author

@kperryua oh sorry didn't realize it. thank you!

@hjyamauchi hjyamauchi closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants