Skip to content

Use U_EXPORT instead of U_EXPORT2 for non-function symbol #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2024
Merged

Use U_EXPORT instead of U_EXPORT2 for non-function symbol #31

merged 1 commit into from
Jul 15, 2024

Conversation

parkera
Copy link
Contributor

@parkera parkera commented Jul 14, 2024

U_EXPORT2 uses __cdecl which is for functions only.

@parkera
Copy link
Contributor Author

parkera commented Jul 14, 2024

@swift-ci test

@parkera parkera mentioned this pull request Jul 14, 2024
Closed
@parkera parkera merged commit a7cbb14 into swiftlang:main Jul 15, 2024
@parkera parkera deleted the parkera/export_fix branch July 15, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmschonfeld jmschonfeld jmschonfeld approved these changes

@iCharlesHu iCharlesHu Awaiting requested review from iCharlesHu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parkera @jmschonfeld