Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove check for prioritizeKeepingFunctionOutputTogether on enum decl. #728

Merged
merged 1 commit into from
May 1, 2024
Merged

Remove check for prioritizeKeepingFunctionOutputTogether on enum decl. #728

merged 1 commit into from
May 1, 2024

Conversation

shawnhyam
Copy link
Contributor

Fixes #726. An enum decl won't have a corresponding .close, so we shouldn't add a .open token.

@shawnhyam shawnhyam requested a review from ahoppen April 29, 2024 15:56
@shawnhyam
Copy link
Contributor Author

This change will also make #725 format as desired when the prioritizeKeepingFunctionOutputTogether flag is enabled.

@shawnhyam shawnhyam requested a review from allevato April 30, 2024 19:52
@allevato allevato mentioned this pull request Apr 30, 2024
Open
allevato
allevato approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@allevato allevato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@allevato allevato merged commit 366da31 into swiftlang:main May 1, 2024
@ahoppen ahoppen mentioned this pull request May 2, 2024
Merged
@shawnhyam shawnhyam deleted the fix-crash-on-enum-decl branch May 29, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allevato allevato allevato approved these changes

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@shawnhyam @allevato