Change function signatures of expansion functions of macros to be synchronous
#2546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
sync-expansion-function
branch
from
b485187 to
9f0ce55
Compare
xwu
added
content change
|
@ahoppen Would you mind adding a line to the revision history of attached macros as well? Otherwise, the LSG has agreed we should update the proposals as shown here and I will post an announcement on it. |
…ynchronous The different macro proposals have been inconsistent about whether the expansion function should be synchronous or asynchronous. - Synchronous - SE-0415 Function Body Macros - SE-0402 Extension Macros - SE-0407 Member Macro Conformances - SE-0397 Freestanding Declaration Macros (but future directions uses `async` function) - Async - SE-0389 Attached Macros - SE-0382 Expression Macros swift-syntax has always implemented synchronous expansion functions. Update the proposals to consistently use synchronous expansion functions to reflect that.
ahoppen
force-pushed
the
sync-expansion-function
branch
from
9f0ce55 to
295276e
Compare
|
@xwu Updated the attached macros proposal to have an entry in the revision history |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The different macro proposals have been inconsistent about whether the expansion function should be synchronous or asynchronous.
asyncfunction)swift-syntax has always implemented synchronous expansion functions. Update the proposals to consistently use synchronous expansion functions to reflect that.