Skip to content

[Explicit Module Builds] Centralize computing *all* dependencies of a given ModuleInfo and use throughout #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Apr 10, 2025

This is in preparation of dependency scanner turning the directDependencies field to contain only actually-directly-imported modules.

@artemcm artemcm requested a review from owenv April 10, 2025 18:09
@artemcm
Copy link
Contributor Author

artemcm commented Apr 10, 2025

@swift-ci test

@artemcm artemcm force-pushed the AlwaysAllDependenciesAllTheTime branch from 15f93bc to f04f086 Compare April 10, 2025 18:15
@artemcm
Copy link
Contributor Author

artemcm commented Apr 10, 2025

@swift-ci test

@artemcm artemcm force-pushed the AlwaysAllDependenciesAllTheTime branch from f04f086 to d4e2d4c Compare April 10, 2025 22:07
@artemcm
Copy link
Contributor Author

artemcm commented Apr 10, 2025

@swift-ci test

@artemcm artemcm force-pushed the AlwaysAllDependenciesAllTheTime branch from d4e2d4c to aa564ae Compare April 10, 2025 22:20
@artemcm
Copy link
Contributor Author

artemcm commented Apr 10, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Apr 10, 2025

@swift-ci test Windows platform

… given 'ModuleInfo' and use throughout

This is in preparation of dependency scanner turning the 'directDependencies' field to contain only actually-directly-imported modules.
@artemcm artemcm force-pushed the AlwaysAllDependenciesAllTheTime branch from aa564ae to c114130 Compare April 10, 2025 23:05
@artemcm
Copy link
Contributor Author

artemcm commented Apr 10, 2025

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Apr 10, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Apr 11, 2025

@swift-ci test Windows platform

Copy link
Contributor

@cachemeifyoucan cachemeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artemcm artemcm merged commit 0c2ef21 into swiftlang:main Apr 14, 2025
3 checks passed
@artemcm artemcm deleted the AlwaysAllDependenciesAllTheTime branch April 14, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants