Add additional valid args to sanitize-coverage flag #1604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
approved these changes
May 13, 2024
Adds valid arguments to sanitizer-coverage pc-table and inline-8bit-counter. Currently you cannot set all default fuzzer options directly using sanitizer coverage. Right now you can choose default fuzzer args, or a limited number coverage options. This PR extends coverage options to allow pc-table and inline-8bit-counter. This algins with default fuzzer options to allow customizing sanitizer-coverage in variations of fuzzer defaults. (i.e. Fuzzer defaults w/o pc-table enabled). In upstream llvm the option -no-sanitize-coverage exists to disable various fuzzing options. Swift current does not have a convention of using excluding args. This aims to limit the need for that by being able to inclusively set desired coverage. rdar://127950283
thetruestblue
force-pushed
the
add-sanitizer-coverage-args
branch
from
ab8fb98 to
22b901e
Compare
thetruestblue
requested review from
yln,
devincoughlin,
rsundahl,
wrotki and
usama54321
|
@swift-ci test |
artemcm
approved these changes
May 14, 2024
|
@swift-ci please test Windows |
usama54321
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds valid arguments to -sanitize-coverage:
pc-tableandinline-8bit-counter.As is, you cannot set all default fuzzer options directly using -sanitize-coverage. Because of this you can use default fuzzer sanitize-coverage args, or a limited number coverage options.
This PR adds options to allow
pc-tableandinline-8bit-counteras valid args. These are default fuzzer options -- and will allow customizing sanitizer-coverage in variations of fuzzer defaults. (i.e. w/opc-tableenabled).In upstream clang the option -fno-sanitize-coverage exists to disable various coverage options. Swift currently does not have a convention of using excluding args for sanitizer flags. This aims to limit the need for a new flag by inclusively setting desired coverage up to current fuzzer defaults.
corresponding change in swift: swiftlang/swift#73587
rdar://127950283