[Caching] Fix incremental cache build with bridging header #1498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
benlangmuir
reviewed
Dec 1, 2023
Sources/SwiftDriver/IncrementalCompilation/IncrementalCompilationProtectedState.swift
Outdated
Show resolved
Hide resolved
artemcm
reviewed
Dec 1, 2023
Sources/SwiftDriver/IncrementalCompilation/IncrementalCompilationProtectedState.swift
Outdated
Show resolved
Hide resolved
When planning a caching build with bridging header, the consumer of the pre-compiled bridging header needs to know the cache key for the bridging header in order to construct the correct build command, which requires visibility to the job that creates PCH. Fix the incremental planning for bridging header users so those job can be correctly constructed even the bridging header job is skipped for the incremental build. rdar://118143215
cachemeifyoucan
force-pushed
the
eng/PR-swift-caching-incremental-build-bridging-header
branch
from
8503254 to
dd7d4c6
Compare
|
@swift-ci please test |
|
Ping |
artemcm
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When planning a caching build with bridging header, the consumer of the pre-compiled bridging header needs to know the cache key for the bridging header in order to construct the correct build command, which requires visibility to the job that creates PCH.
Fix the incremental planning for bridging header users so those job can be correctly constructed even the bridging header job is skipped for the incremental build.
rdar://118143215