Skip to content

[5.9 🍒] Miscellaneous Dependency Scanner and Explicit Modules Improvements #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Jun 26, 2023

Cherry-pick of #1365 and #1363

• Release: Swift 5.9
• Explanation: Cherry-picks of a handful of changes to the dependency scanner, in order to facilitate early experimental adoption of explicit module loading in release compilers. Also cherry-picks the new -explain-dependency option, which is purely an opt-in feature and does not affect existing code paths.
• Scope of Issue: This issue impacts only users who opt-in to Explicit Module Builds with the driver's -experimental-explicit-module-build.
• Origination: Development of Explicit Module loading
• Risk: The risk of this change is low, affected code-paths are not triggered during Implicit Module builds (default)
• Reviewed By: @nkcsgexi

… separate dependency details field

Instead of assuming such dependencies are contained in the 'directDependencies' field of the module info, support querying them from a details of a textual module.
@artemcm artemcm requested a review from nkcsgexi June 26, 2023 21:11
@artemcm
Copy link
Contributor Author

artemcm commented Jun 26, 2023

@swift-ci test

Adds support for '-explain-dependency <MODULE_NAME>', which causes the driver to run a dependency scan, and find all dependency paths that cause the main module to depend, directly or transitively, on a given module dependency.
@artemcm artemcm force-pushed the ExplicitModule59CherrySeason branch from 26daecd to 122976b Compare June 26, 2023 22:51
@artemcm
Copy link
Contributor Author

artemcm commented Jun 26, 2023

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Jun 27, 2023

@swift-ci test Windows platform

2 similar comments
@artemcm
Copy link
Contributor Author

artemcm commented Jun 27, 2023

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Jun 27, 2023

@swift-ci test Windows platform

@artemcm artemcm merged commit b8c7ccf into swiftlang:release/5.9 Jun 28, 2023
@artemcm artemcm deleted the ExplicitModule59CherrySeason branch June 28, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants