[5.9][Macros] Set -external-plugin-path when the toolchain is not Xcode #1340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
rintaro
force-pushed
the
5.9-macros-external-plugin-path
branch
from
b5c2e65 to
805fde5
Compare
rintaro
changed the title
|
@swift-ci Please test |
rdar://108525615 (cherry picked from commit 53ad3a9)
rintaro
force-pushed
the
5.9-macros-external-plugin-path
branch
from
805fde5 to
9f5ad9b
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
DougGregor
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #1320 into
release/5.9Explanation: swiftlang/swift#64376 implemented "plugin server". This change is a corresponding change in
swift-driverthat utilize the plugin-server when the currentswiftcis not in the Xcode.Scope: Frontend options in macOS environment.
Risk: low
Testing: Added a regression test case
Issues: rdar://108525615
Reviewer: Artem Chickin (@artemcm)