Skip to content

Use libSwiftScan API to query compilation "Target Info" #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2023
Merged

Use libSwiftScan API to query compilation "Target Info" #1268

merged 2 commits into from
Jan 25, 2023

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Jan 19, 2023

No description provided.

@artemcm artemcm force-pushed the TargetInfoDefinitive branch 3 times, most recently from 42975e9 to 7172392 Compare January 19, 2023 17:01
This was referenced Jan 19, 2023
Closed
Merged
@artemcm
Copy link
Contributor Author

artemcm commented Jan 19, 2023

@swift-ci test

@artemcm artemcm force-pushed the TargetInfoDefinitive branch from 7172392 to 7440d15 Compare January 19, 2023 18:56
@artemcm
Copy link
Contributor Author

artemcm commented Jan 19, 2023

@swift-ci test macOS Platform

@artemcm artemcm force-pushed the TargetInfoDefinitive branch from 7440d15 to 7cefce5 Compare January 20, 2023 18:45
This was referenced Jan 20, 2023
Closed
Closed
@artemcm
Copy link
Contributor Author

artemcm commented Jan 20, 2023

@swift-ci test

@artemcm artemcm force-pushed the TargetInfoDefinitive branch from 7cefce5 to 7549f3c Compare January 20, 2023 20:07
@artemcm
Copy link
Contributor Author

artemcm commented Jan 20, 2023

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Jan 20, 2023

@swift-ci test macOS platform

@artemcm artemcm requested review from owenv and nkcsgexi January 20, 2023 23:26
nkcsgexi
nkcsgexi approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we finally got to the bottom of the memory corruption issue👍

owenv
owenv approved these changes Jan 23, 2023
View reviewed changes
@artemcm artemcm force-pushed the TargetInfoDefinitive branch from 7549f3c to 4f559f8 Compare January 23, 2023 22:36
@artemcm
Copy link
Contributor Author

artemcm commented Jan 23, 2023

@swift-ci test

@artemcm
Switch over to using V2 of the swiftscan_compiler_target_info_query API
dc63fac 
This new version takes the path to the compiler executable as a parameter, in order for libSwiftScan to compute compiler-relative portions of runtimeLibraryPaths, runtimeResourcePath, etc.
@artemcm artemcm force-pushed the TargetInfoDefinitive branch from 4f559f8 to dc63fac Compare January 24, 2023 17:09
@artemcm
Copy link
Contributor Author

artemcm commented Jan 24, 2023

@swift-ci test

@artemcm artemcm merged commit 15ff8a3 into swiftlang:main Jan 25, 2023
@artemcm artemcm deleted the TargetInfoDefinitive branch January 25, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenv owenv owenv approved these changes

@nkcsgexi nkcsgexi nkcsgexi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artemcm @owenv @nkcsgexi