Skip to content

Commit 46d90b1

Browse files
committed
Construct the job description string in a way that doesn't retain trailing spaces if the rhs is nil
1 parent ee46ec9 commit 46d90b1

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

Sources/SwiftDriver/Jobs/Job.swift

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -167,9 +167,13 @@ extension Job {
167167

168168
extension Job : CustomStringConvertible {
169169
public var description: String {
170+
func join(_ parts: String?...) -> String {
171+
return parts.compactMap { $0 }.joined(separator: " ")
172+
}
173+
170174
switch kind {
171175
case .compile:
172-
return "Compiling \(moduleName) \(displayInputs.first?.file.basename ?? "")"
176+
return join("Compiling \(moduleName)", displayInputs.first?.file.basename)
173177

174178
case .mergeModule:
175179
return "Merging module \(moduleName)"
@@ -187,7 +191,7 @@ extension Job : CustomStringConvertible {
187191
return "Emitting module for \(moduleName)"
188192

189193
case .generatePCH:
190-
return "Compiling bridging header \(displayInputs.first?.file.basename ?? "")"
194+
return join("Compiling bridging header", displayInputs.first?.file.basename)
191195

192196
case .moduleWrap:
193197
return "Wrapping Swift module \(moduleName)"
@@ -196,10 +200,10 @@ extension Job : CustomStringConvertible {
196200
return "Compiling Clang module \(moduleName)"
197201

198202
case .dumpPCM:
199-
return "Dump information about Clang module \(displayInputs.first?.file.name ?? "")"
203+
return join("Dump information about Clang module", displayInputs.first?.file.name)
200204

201205
case .interpret:
202-
return "Interpreting \(displayInputs.first?.file.name ?? "")"
206+
return join("Interpreting", displayInputs.first?.file.name)
203207

204208
case .repl:
205209
return "Executing Swift REPL"
@@ -217,7 +221,7 @@ extension Job : CustomStringConvertible {
217221
return "Swift help"
218222

219223
case .backend:
220-
return "Embedding bitcode for \(moduleName) \(displayInputs.first?.file.basename ?? "")"
224+
return join("Embedding bitcode for \(moduleName)", displayInputs.first?.file.basename)
221225

222226
case .emitSupportedFeatures:
223227
return "Emitting supported Swift compiler features"

0 commit comments

Comments
 (0)