Revert "Disable integration tests that fail because of rdar://134406349 (#90)" (#91)

This reverts commit 6c596f1.

Co-authored-by: Andrea Fernandez Buitrago <15234535+anferbui@users.noreply.github.com>

Author: d-ronnqvist

IntegrationTests/Tests/SnippetDocumentationGenerationTests.swift

@@ -44,9 +44,6 @@ final class SnippetDocumentationGenerationTests: ConcurrencyRequiringTestCase {
     }
 
     func testPreviewDocumentationWithSnippets() throws {
-#if os(macOS)
-        throw XCTSkip("Skipping integration tests due to rdar://134406349")
-#else
         let outputDirectory = try temporaryDirectory().appendingPathComponent("output")
 
         let port = try getAvailablePort()
@@ -105,6 +102,5 @@ final class SnippetDocumentationGenerationTests: ConcurrencyRequiringTestCase {
 
         // Send an interrupt to the SwiftPM parent process
         process.interrupt()
-#endif
     }
 }

IntegrationTests/Tests/SwiftDocCPreviewTests.swift

@@ -11,9 +11,6 @@ import XCTest
 
 final class SwiftDocCPreview: ConcurrencyRequiringTestCase {
     func testRunPreviewServerOnSamePortRepeatedly() throws {
-#if os(macOS)
-        throw XCTSkip("Skipping integration tests due to rdar://134406349")
-#else
         // Because only a single server can bind to a given port at a time,
         // this test ensures that the preview server running in the `docc`
         // process exits when the an interrupt is sent to the `SwiftPM` process.
@@ -113,6 +110,5 @@ final class SwiftDocCPreview: ConcurrencyRequiringTestCase {
             // Send an interrupt to the SwiftPM parent process
             process.interrupt()
         }
-#endif
     }
 }

IntegrationTests/Tests/Utility/XCTestCase+swiftPackage.swift

@@ -96,20 +96,15 @@ extension XCTestCase {
         }
 
         return try processQueue.sync {
-            let standardOutputString = String(data: standardOutputData, encoding: .utf8) ?? ""
-            let standardErrorString = String(data: standardErrorData, encoding: .utf8) ?? ""
+            let standardOutputString = String(data: standardOutputData, encoding: .utf8)
+            let standardErrorString = String(data: standardErrorData, encoding: .utf8)
 
-            
-            if process.terminationStatus != 0, standardErrorString.contains("<unknown>:0: error: unknown argument: ") {
-                throw XCTSkip("Skipping integration tests due to rdar://134406349")
-            }
-            
             return SwiftInvocationResult(
                 workingDirectory: directoryURL,
                 swiftExecutable: try swiftExecutableURL,
                 arguments: arguments.map(\.description),
-                standardOutput: standardOutputString ,
-                standardError: standardErrorString,
+                standardOutput: standardOutputString ?? "",
+                standardError: standardErrorString ?? "",
                 exitStatus: Int(process.terminationStatus)
             )
         }