[XCTAssert] s/__FILE__/#file/g, s/__LINE__/#line/g #48
Conversation
"Screaming snake case" debugging identifiers like `__FILE__` and `__LINE__` are scheduled to be removed as per evolution proposal SE-0028 (https://github.com/apple/swift-evolution/blob/6e040b5d5d19df60329deffc125552a4cd63a21d/proposals/0028-modernizing-debug-identifiers.md). They were marked as deprecated in swiftlang/swift@0619e57#diff-b1b9777d77a07ee6e082cce7a2c52608R87. Replace all uses of `__FILE__` with `#file`, and `__LINE__` with `#line`. Keep in mind that this means people using swift-corelibs-xctest must build the latest version of Swift from source (which includes the commit referenced above) in order to maintain compatibility. To run the tests on OS X, users must launch Xcode pointing to a toolchain built from the latest source.
|
Let me ask around here a bit about staging of the Swift change... We'll certainly take this eventually, but it may be that waiting a bit will be a bit more convenient. |
|
Sounds reasonable. Waiting for the next snapshot, which will include the new |
|
@mike-ferris-apple This can probably go in now that https://github.com/apple/swift/tree/swift-DEVELOPMENT-SNAPSHOT-2016-02-08 has been tagged. Users who encounter build errors should be encouraged to migrate to the latest snapshot. |
|
@mike-ferris-apple @modocache agreed - this should be merged pretty soon now, as it needs to be included in the next snapshot, or else XCTest will fail to build. |
[XCTAssert] s/__FILE__/#file/g, s/__LINE__/#line/g
|
I'll go ahead and merge this. |
|
Great, thanks! |
Allow swift-corelibs-xctest to be built and tested on Linux and OS X, via `utils/build-script --xctest --test`. On OS X, XCTest is built via `xcodebuild`, which has been possible since swiftlang/swift-corelibs-xctest#47. It's tested via the "SwiftXCTestFunctionalTests" Xcode target. Keep in mind that `xcodebuild` must be configured on the host machine to use a Swift toolchain that can build XCTest--as of swiftlang/swift-corelibs-xctest#48, that would be `swift-DEVELOPMENT-SNAPSHOT-2016-02-08` or later. On Linux, XCTest is built and tested via the project's `build_script.py`, which has been possible since swiftlang/swift-corelibs-xctest#46.
"Screaming snake case" debugging identifiers like
__FILE__and__LINE__are scheduled to be removed as per evolution proposal SE-0028. They were marked as deprecated in swiftlang/swift@0619e57#diff-b1b9777d77a07ee6e082cce7a2c52608R87.Replace all uses of
__FILE__with#file, and__LINE__with#line. This fixes compilation warnings emitted when building swift-corelibs-xctest with the latest version of Swift.