Skip to content

Add more comments for #endif in .h file. #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Add more comments for #endif in .h file. #837

wants to merge 11 commits into from

Conversation

lamtrinhdev
Copy link
Contributor

This is a long .h file. I would like to are more comment for #endif

@lamtrinhdev
Update base.h
cc1fe81 
Add more comments.
@lamtrinhdev
Update dispatch.h
2a33f6a 
Add more comments.
@lamtrinhdev
Update group.h
cf24c87 
Add more comments.
@lamtrinhdev
Update base.h
7472492 
Update comment.
@lamtrinhdev
Update dispatch.h
5beff0d 
Update comment.
@lamtrinhdev
Update introspection.h
d446d91 
Add more comments.
@lamtrinhdev
Update object.h
b421a93 
Add more comments.
@lamtrinhdev
Update once.h
bf28752 
Add more comments.
@lamtrinhdev
Update queue.h
d969b7c 
Add more comments.
@lamtrinhdev
Update source.h
4336117 
Add more comments.
@lamtrinhdev
Update time.h
907677a 
Add more comments.
@lamtrinhdev
Copy link
Contributor Author

Dear @rokhinip ,

The header file h is too long. I would like to add more some minor comments for knowing the end of define. Please help me to review it.

Thanks,
Lam

@rokhinip
Copy link
Contributor

rokhinip commented Aug 1, 2024

Please squash your changes into a single commit.

@lamtrinhdev
Copy link
Contributor Author

lamtrinhdev commented Aug 2, 2024 •
edited
Loading

Dear @rokhinip ,

Thank you for your feedback. I just create the new PR with single comment that is #839 . Let me close this PR.

Thanks,
Lam

@lamtrinhdev lamtrinhdev closed this Aug 2, 2024
@lamtrinhdev lamtrinhdev mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lamtrinhdev @rokhinip