dispatch: use auto-reset event for dispatch queue #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an auto-reset event for the dispatch queue on Windows. On Linux, `eventfd` is used, which is auto-reset unless `EFD_SEMAPHORE` is specified. This mirrors that behaviour. The test suite continues to pass after this change.
|
@swift-ci please test |
|
CC: @adierking |
MadCoder
approved these changes
May 26, 2020
|
LGTM - CF on Windows only does |
|
@swift-ci please test |
|
Hmm, I think that this is a problem in the CI: Seems like a python version/encoding issue |
|
@swift-ci please test |
lxbndr
added a commit
to readdle/swift-corelibs-foundation
that referenced
this pull request
May 27, 2020
This ensures CFRunLoop correctly serves main dispatch queue. Due to event specifics on Windows there was possibility to break RunLoop making it think that main queue always has pending work. The issue is adressed in swiftlang/swift-corelibs-libdispatch#542.
|
@swift-ci please test |
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
dispatch: use auto-reset event for dispatch queue Signed-off-by: Rokhini Prabhu <rokhinip@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an auto-reset event for the dispatch queue on Windows. On Linux,
eventfdis used, which is auto-reset unlessEFD_SEMAPHOREisspecified. This mirrors that behaviour. The test suite continues to
pass after this change.