Add clean failure for EVFILT_PROC usage #23
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request does a couple of things:
dispatch_proc
test by resolving the compile issue around the usage ofPOSIX_SPAWN_START_SUSPENDED
by wrapping it in a#if
preprocessorsource.c
to returnNULL
for calls todispatch_source_create()
withDISPATCH_SOURCE_TYPE_PROC
if the underlying usage ofEVFILT_PROC
isn't supported by thekqueue
implementation available.The second part is implemented in autoconf by using
AC_RUN_PROGRAM
.I looked at whether the
ENOSYS
reported bykevent64()
could be percolated up todispatch_source_create()
at runtime, but I couldn't seen an elegant way to so so.Additionally,
EVFILT_PROC
is correctly defined inqueue\sys\event.h
even though its usage is not supported, so it wasn't possible to do a simple definition check.Let me know what you think, and if you have any suggestions for alternative approaches.