Add AC_SEARCH_LIBS stanzas for kqueue and pthread_workqueue #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If libdispatch is using functions found in libkqueue or libpthread_workqueue, then we want libdispatch.so to depend on those libraries. Putting in AC_SEARCH_LIBS stanzas results in the proper linker flags being added when libdispatch.so is built. Therefore the application compilation command can simply say -ldispatch and not need to explicitly mention -lkqueue and -lpthread_workqueue.
|
Redone change as suggested and submitted a new pull request. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If libdispatch is using functions found in libkqueue or
libpthread_workqueue, then we want libdispatch.so to
depend on those libraries. Putting in AC_SEARCH_LIBS
stanzas results in the proper linker flags being added when
libdispatch.so is built. Therefore the application compilation
command can simply say -ldispatch and not need to explicitly
mention -lkqueue and -lpthread_workqueue.