Skip to content

Commit eff2273

Browse files
committed
Revert modulemaps changes from PR #94
The Linux and Darwin module maps need to be kept separate as they have different linkage requirements. <rdar://problem/27366695> Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
1 parent 627df61 commit eff2273

File tree

4 files changed

+25
-15
lines changed

4 files changed

+25
-15
lines changed

dispatch/Makefile.am

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,5 @@ dispatch_HEADERS= \
2424
time.h
2525

2626
if HAVE_SWIFT
27-
dispatch_HEADERS+=module.modulemap
27+
dispatch_HEADERS+=module.map
2828
endif

dispatch/module.map

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
module Dispatch {
2+
requires blocks
3+
export *
4+
link "dispatch"
5+
link "BlocksRuntime"
6+
}
7+
8+
module DispatchIntrospection [system] [extern_c] {
9+
header "introspection.h"
10+
export *
11+
}
12+
13+
module CDispatch [system] [extern_c] {
14+
umbrella header "dispatch.h"
15+
module * { export * }
16+
export *
17+
requires blocks
18+
link "dispatch"
19+
link "BlocksRuntime"
20+
}

dispatch/module.modulemap

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,10 @@
1-
module Dispatch {
2-
requires blocks
1+
module Dispatch [system] [extern_c] {
2+
umbrella header "dispatch.h"
3+
module * { export * }
34
export *
4-
link "dispatch"
5-
link "BlocksRuntime"
65
}
76

87
module DispatchIntrospection [system] [extern_c] {
98
header "introspection.h"
109
export *
1110
}
12-
13-
module CDispatch [system] [extern_c] {
14-
umbrella header "dispatch.h"
15-
module * { export * }
16-
export *
17-
requires blocks
18-
link "dispatch"
19-
link "BlocksRuntime"
20-
}

src/Makefile.am

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ SWIFT_GEN_FILES= \
149149
$(SWIFT_OBJ_FILES:%=%.~partial.swiftdoc) \
150150
$(SWIFT_OBJ_FILES:%=%.~partial.swiftdeps)
151151

152-
SWIFTC_FLAGS = -Xcc -fmodule-map-file=$(abs_top_srcdir)/dispatch/module.modulemap -I$(abs_top_srcdir) -Xcc -fblocks
152+
SWIFTC_FLAGS = -Xcc -fmodule-map-file=$(abs_top_srcdir)/dispatch/module.map -I$(abs_top_srcdir) -Xcc -fblocks
153153

154154
$(abs_builddir)/swift/%.o: $(abs_srcdir)/swift/%.swift
155155
$(SWIFTC) -frontend -c $(SWIFT_ABS_SRC_FILES) -primary-file $< \

0 commit comments

Comments
 (0)