[5.9] Forward unit test concurrency fix from main #4790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Notify-concurrency-bug Fix a concurrency bug in the TestFileHandle.test_readToEndOfFileAndNotify() unit test.
|
@swift-ci please test |
parkera
approved these changes
Jun 29, 2023
|
macOS build failure appears to be infrastructural. I've reached out to the CI owners for assistance. |
|
@swift-ci please test macOS |
|
@swift-ci please test macOS platform |
|
@swift-ci please test macOS |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
Unfortunately we were not able to resolve the build failure on macOS. |
|
@swift-ci test |
briancroom
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: swift-corelibs-xctest is adopting some changes in 5.9 to improve concurrency support. This change fixes a unit test in this package that currently fails (due to a real bug in the test) when the XCTest changes are applied.
Scope: A fix to a unit test only. No effect on the primary package target.
Issue: #4787
Risk: No obvious risk.
Testing: Simply run the unit test and confirm it builds and passes.
Reviewer: @parkera et al.