Process: check for posix_spawn_file_actions_addchdir_np
#4763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
Lukasa
reviewed
Jun 15, 2023
Sources/Foundation/Process.swift
Outdated
|
|
||
| // Reset the previous working directory path. | ||
| fileManager.changeCurrentDirectoryPath(previousDirectoryPath) |
There was a problem hiding this comment.
This is a semantic change: we must restore this if closure throws.
There was a problem hiding this comment.
good catch, thanks!
|
@swift-ci smoke test |
|
@swift-ci test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
|
@swift-ci test macos |
|
@MaxDesiatov Note that macOS has |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before calling
posix_spawn_file_actions_addchdir_npwe should check if it's available. On non-Linux platform where we know it can't be available we're taking a faster path that doesn't check at run time.Resolves #4762.