Update to support the latest Corelibs XCTest #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,7 +81,7 @@ class TestNSString : XCTestCase { | |||
| ("test_ExternalRepresentation", test_ExternalRepresentation), | |||
| ("test_mutableStringConstructor", test_mutableStringConstructor), | |||
| ("test_PrefixSuffix", test_PrefixSuffix), | |||
| ("test_reflection", test_reflection), | |||
| ("test_reflection", { _ in test_reflection }), | |||
There was a problem hiding this comment.
unrelated to this change but we should consider moving this into an actual test scope.
|
Overall looks good to me, as soon as swiftlang/swift-corelibs-xctest#40 is merged we should bring this in as well |
briancroom
force-pushed
the
update_allTests
branch
from
a23b0c6 to
6f34430
Compare
mike-ferris
pushed a commit
that referenced
this pull request
Mar 2, 2016
Update to support the latest Corelibs XCTest
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
[test] Fix data race in build system test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the necessary changes for the test suite to build and run with the
swift-corelibs-xctestchanges proposed in swiftlang/swift-corelibs-xctest#40 and should be merged in coordination with that PR.