[CF] Expose flsl and narrow scope of popcountll. #2621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefix defines popcountll for Linux and Windows. The only references to popcountll exist in CFBurstTrie, and the Prefix implementation is only used there when TARGET_OS_WIN32. Therefore, there's no need to expose this outside of Windows.
spevans
reviewed
Jan 21, 2020
flsl is available on FreeBSD (and thus macOS), but not OpenBSD. This commit makes the implementation of flsl currently exposed to Linux and Windows also available to OpenBSD. Thus, we can move this implementation up to the existing block of shared infrastructure. Additionally, this commit separates it from the block below which declares asprintf. The asprintf declaration is still required for Linux and Windows, but not OpenBSD. While we are here, move an existing comma loop body to explicit braces.
3405691582
force-pushed
the
Prefix_ExposeIntrinsics
branch
from
2edc38f to
f631bd6
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR encloses two primarily mechanical commits that deal with the scoping of the implementations of two intrinsic/like functions.
Prefix defines popcountll for Linux and Windows. The only references to
popcountll exist in CFBurstTrie, and the Prefix implementation is only
used there when TARGET_OS_WIN32. Therefore, there's no need to expose
this outside of Windows.
flsl is available on FreeBSD (and thus macOS), but not OpenBSD. This
commit makes the implementation of flsl currently exposed to Linux and
Windows also available to OpenBSD.