ObjCBool: Add boolValue property

- Update uses of Bool to ObjCBool where appropiate

Author: spevans

Foundation/NSSwiftRuntime.swift

@@ -25,6 +25,9 @@ import CoreFoundation
 #endif
 
 public typealias ObjCBool = Bool
+extension ObjCBool {
+    public var boolValue: Bool { return self == true }
+}
 
 internal class __NSCFType : NSObject {
     private var _cfinfo : Int32

TestFoundation/TestFileManager.swift

@@ -53,10 +53,10 @@ class TestFileManager : XCTestCase {
         // Ensure attempting to create the directory again fails gracefully.
         XCTAssertNil(try? fm.createDirectory(atPath: path, withIntermediateDirectories:false, attributes:nil))
 
-        var isDir = false
+        var isDir: ObjCBool = false
         let exists = fm.fileExists(atPath: path, isDirectory: &isDir)
         XCTAssertTrue(exists)
-        XCTAssertTrue(isDir)
+        XCTAssertTrue(isDir.boolValue)
 
         do {
             try fm.removeItem(atPath: path)
@@ -74,10 +74,10 @@ class TestFileManager : XCTestCase {
 
         XCTAssertTrue(fm.createFile(atPath: path, contents: Data(), attributes: nil))
 
-        var isDir = false
+        var isDir: ObjCBool = false
         let exists = fm.fileExists(atPath: path, isDirectory: &isDir)
         XCTAssertTrue(exists)
-        XCTAssertFalse(isDir)
+        XCTAssertFalse(isDir.boolValue)
 
         do {
             try fm.removeItem(atPath: path)
@@ -467,9 +467,9 @@ class TestFileManager : XCTestCase {
         }
 
         func directoryExists(atPath path: String) -> Bool {
-            var isDir = false
+            var isDir: ObjCBool = false
             let exists = fm.fileExists(atPath: path, isDirectory: &isDir)
-            return exists && isDir
+            return exists && isDir.boolValue
         }
 
         func createDirectory(atPath path: String) {

TestFoundation/TestHTTPCookieStorage.swift

@@ -238,7 +238,7 @@ class TestHTTPCookieStorage: XCTestCase {
             destPath = NSHomeDirectory() + "/.local/share" + bundleName + "/.cookies.shared"
         }
         let fm = FileManager.default
-        var isDir = false
+        var isDir: ObjCBool = false
         let exists = fm.fileExists(atPath: destPath, isDirectory: &isDir)
         XCTAssertTrue(exists)
         //Test by setting the environmental variable

TestFoundation/TestUtils.swift

@@ -41,7 +41,7 @@ func ensureFiles(_ fileNames: [String]) -> Bool {
                     print(err)
                     return false
                 }
-            } else if !isDir {
+            } else if !isDir.boolValue {
                 return false
             }