Initial support for tracking locations for assigned values in XCConfigs #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
requested review from
aciidgh,
jakepetroules,
mirza-garibovic,
mhrawdon and
owenv
as code owners
|
@swift-ci please test |
|
Note that this currently only tracks one location per macro, I wanted to separate the mechanics a bit from the interesting parts, so there will be at least one more PR before this really becomes useful in practice. |
This can be used to emit fix-its for XCConfigs files during the build process.
neonichu
force-pushed
the
bbuegling/retain-xcconfig-value-locations
branch
from
fd1477f to
a619ee1
Compare
|
@swift-ci please test |
owenv
reviewed
May 19, 2025
| @@ -396,6 +423,37 @@ public final class MacroValueAssignment: Serializable, CustomStringConvertible, | |||
| } | |||
| } | |||
|
|
|||
| public struct MacroValueAssignmentLocation: Serializable, Sendable { | |||
| public let path: Path | |||
There was a problem hiding this comment.
I wonder if we're going to end up wanting to intern these strings somewhere to cut down on memory usage in projects with large settings tables
There was a problem hiding this comment.
Yah, that's a good point. I think settings already track paths of XCConfigs for invalidation purposes, maybe we can re-use that instead of duplicating the paths per macro like I am doing here.
owenv
approved these changes
May 19, 2025
jakepetroules
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used to emit fix-its for XCConfigs files during the build process.