Remove -index-store-path for clang vendor is not Apple (#142)

* Remove -index-store-path if not clang vendor not Apple

* Fix Apple Clang Detection

* Update: Overriding COMPILER_INDEX_STORE_ENABLE to NO for non-Apple Clangs

Author: swiftlysingh

Sources/SWBCore/SpecImplementations/Tools/CCompiler.swift

@@ -612,7 +612,15 @@ public class ClangCompilerSpec : CompilerSpec, SpecIdentifierType, GCCCompatible
         var commandLine = Array<String>()
 
         // Add the arguments from the specification.
-        commandLine += self.commandLineFromOptions(producer, scope: scope, inputFileType: inputFileType, optionContext: optionContext).map(\.asString)
+        commandLine += self.commandLineFromOptions(producer, scope: scope, inputFileType: inputFileType, optionContext: optionContext,lookup: { declaration in
+            if declaration.name == "CLANG_INDEX_STORE_ENABLE" && optionContext is DiscoveredClangToolSpecInfo {
+                let clangToolInfo = optionContext as! DiscoveredClangToolSpecInfo
+                if !clangToolInfo.isAppleClang {
+                    return BuiltinMacros.namespace.parseString("NO")
+                }
+            }
+            return nil
+        }).map(\.asString)
 
         // Add the common header search paths.
         let headerSearchPaths = GCCCompatibleCompilerSpecSupport.headerSearchPathArguments(producer, scope, usesModules: scope.evaluate(BuiltinMacros.CLANG_ENABLE_MODULES))

Sources/SWBCore/ToolInfo/ClangToolInfo.swift

@@ -16,6 +16,7 @@ public struct DiscoveredClangToolSpecInfo: DiscoveredCommandLineToolSpecInfo {
     public let toolPath: Path
     public let clangVersion: Version?
     public let llvmVersion: Version?
+    public let isAppleClang: Bool
 
     public var toolVersion: Version? { return self.clangVersion }
 
@@ -79,7 +80,7 @@ public func discoveredClangToolInfo(
 ) async throws -> DiscoveredClangToolSpecInfo {
     // Check that we call a clang variant, 'clang', 'clang++' etc. Note that a test sets `CC` to `/usr/bin/yes` so avoid calling that here.
     guard toolPath.basename.starts(with: "clang") else {
-        return DiscoveredClangToolSpecInfo(toolPath: toolPath, clangVersion: nil, llvmVersion: nil, clangCachingBlocklist: nil, toolFeatures: .none)
+        return DiscoveredClangToolSpecInfo(toolPath: toolPath, clangVersion: nil, llvmVersion: nil, isAppleClang: false, clangCachingBlocklist: nil, toolFeatures: .none)
     }
 
     // Construct the command line to invoke.
@@ -102,6 +103,7 @@ public func discoveredClangToolInfo(
 
         var clangVersion: Version? = nil
         var llvmVersion: Version? = nil
+        var isAppleClang = false
 
         for line in outputString.components(separatedBy: "\n") {
             if line.hasPrefix("#define ") {
@@ -123,6 +125,10 @@ public func discoveredClangToolInfo(
                         llvmVersion = try? Version(String(match.llvm))
                     }
                 }
+
+                if macroName == "__apple_build_version__" {
+                    isAppleClang = true
+                }
             }
         }
 
@@ -157,6 +163,7 @@ public func discoveredClangToolInfo(
             toolPath: toolPath,
             clangVersion: clangVersion,
             llvmVersion: llvmVersion,
+            isAppleClang: isAppleClang,
             clangCachingBlocklist: getBlocklist(type: ClangCachingBlockListInfo.self, toolchainFilename: "clang-caching.json", delegate: delegate),
             toolFeatures: getFeatures(at: toolPath)
         )