Highlight references to actors like references to classes #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/actor-highlighting
branch
from
5b6e910 to
fc9d624
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
bnbarham
approved these changes
Jun 27, 2023
| @@ -91,6 +92,7 @@ public struct SyntaxHighlightingToken: Hashable { | |||
| switch self { | |||
| case .namespace: return "namespace" | |||
| case .type: return "type" | |||
| case .actor: return "class" // Map | |||
There was a problem hiding this comment.
Did you intend to write more for that comment?
There was a problem hiding this comment.
Oh, yes. I got distracted while writing it.
We weren’t semantically highlighting references to actors because we missed the `ref_actor` case from the sourcekitd `annotations` response. Fixes swiftlang#694 rdar://104573568
ahoppen
force-pushed
the
ahoppen/actor-highlighting
branch
from
fc9d624 to
7c15ba8
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren’t semantically highlighting references to actors because we missed the
ref_actorcase from the sourcekitdannotationsresponse.Fixes #694
rdar://104573568