Skip to content

Improvements to build-script.py #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 2, 2022

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jul 29, 2022

This should contain no functionality change. I just

  • added type annotations
  • reordered some code into different functions
  • changed indentation to 4 space to be consistent with Python scripts in the swift repo
  • Removed some dead code

This is a fallout of trying to get sourcekit-lsp and indexstore-db into the unified SwiftPM build.

@ahoppen ahoppen marked this pull request as ready for review July 29, 2022 16:00
@ahoppen ahoppen requested a review from benlangmuir as a code owner July 29, 2022 16:00
@ahoppen ahoppen requested a review from bnbarham July 29, 2022 16:01
@ahoppen ahoppen force-pushed the pr/build-script-improvements branch from 3a614ae to be91d9c Compare July 29, 2022 16:03
@ahoppen
Copy link
Member Author

ahoppen commented Jul 29, 2022

@swift-ci Please test

@ahoppen ahoppen force-pushed the pr/build-script-improvements branch from be91d9c to a196ae6 Compare July 29, 2022 20:24
@ahoppen ahoppen force-pushed the pr/build-script-improvements branch from a196ae6 to 8e21003 Compare July 29, 2022 20:26
@ahoppen
Copy link
Member Author

ahoppen commented Jul 29, 2022

@swift-ci Please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants