Add log messages to track target preparation #1478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These should help us figure out the root cause of rdar://129698768 if we hit it again.
|
@swift-ci Please test |
bnbarham
approved these changes
Jun 12, 2024
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Jun 20, 2024
…nForEditorFunctionality` We fulfilled the `allDocumentsOpened` expectation directly after dispatching the notification to open LibD.swift. This left a very short window in which LibB’s preparation could finish and LibC’s expectation could start before the open notification for LibD.swift was handled, causing an unexpected preparation of LibC. This fixes the issue first reported as rdar://129698768 and for which I added logging in swiftlang#1478.
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Jun 20, 2024
…nForEditorFunctionality` We fulfilled the `allDocumentsOpened` expectation directly after dispatching the notification to open LibD.swift. This left a very short window in which LibB’s preparation could finish and LibC’s expectation could start before the open notification for LibD.swift was handled, causing an unexpected preparation of LibC. This fixes the issue first reported as rdar://129698768 and for which I added logging in swiftlang#1478.
|
The additional logging helped find the underlying issue: #1499 |
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Jun 22, 2024
…nForEditorFunctionality` We fulfilled the `allDocumentsOpened` expectation directly after dispatching the notification to open LibD.swift. This left a very short window in which LibB’s preparation could finish and LibC’s expectation could start before the open notification for LibD.swift was handled, causing an unexpected preparation of LibC. This fixes the issue first reported as rdar://129698768 and for which I added logging in swiftlang#1478. # Conflicts: # Tests/SourceKitLSPTests/BackgroundIndexingTests.swift
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Jun 26, 2024
…nForEditorFunctionality` We fulfilled the `allDocumentsOpened` expectation directly after dispatching the notification to open LibD.swift. This left a very short window in which LibB’s preparation could finish and LibC’s expectation could start before the open notification for LibD.swift was handled, causing an unexpected preparation of LibC. This fixes the issue first reported as rdar://129698768 and for which I added logging in swiftlang#1478.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should help us figure out the root cause of rdar://129698768 if we hit it again.