Address review comments to #1249 #1310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
approved these changes
May 17, 2024
| @@ -406,7 +415,7 @@ extension SwiftPMBuildSystem: SKCore.BuildSystem { | |||
| return [ConfiguredTarget(targetID: "", runDestinationID: "dummy")] | |||
| } | |||
|
|
|||
| if url.pathExtension == "h", let target = try? target(forHeader: path) { | |||
| if let target = try? target(forHeader: path) { | |||
There was a problem hiding this comment.
Ah, I noticed the comment in the other PR before this one:
Did you also rename
target(forHeader:)? MaybeinferTarget(for:)?
There was a problem hiding this comment.
Renamed to inferredTarget(for:).
hamishknight
approved these changes
May 17, 2024
ahoppen
force-pushed
the
review-comments-1249
branch
from
5239f85 to
372673f
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.