-
Notifications
You must be signed in to change notification settings - Fork 342
[rebranch] Various changes to get rebranch compiling #8938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rebranch] Various changes to get rebranch compiling #8938
Conversation
rdar://129359321 Adds SwiftAggLowerign::shouldReturnTypedErrorIndirectly, which checks if a typed error can be returned directly, similar to how shouldPassIndirectly works, but with the additional restriction of the type having to consist of only integers. (cherry picked from commit 7936f81)
Now returns a `std::string` rather than a `ConstString`
…e to be implemented by language plugins (llvm#96290) This patch adds a new `DoPrepareForExecution` API, which can be implemented by the Clang and Swift language plugins. This also moves `RunStaticInitializers` into `ExpressionParser::PrepareForExecution`, so we call it consistently between language plugins. This *should* be mostly NFC (the static initializers will still only run after we finished parsing). We've been living on this patch downstream for sometime now. rdar://130267058 (cherry picked from commit bfd263a)
@drexin your codegen change needs cherry-picking to @ian-twilightcoder I assume I should also cherry-pick the modulemap change to |
@swift-ci please test |
Probably, which modulemap change? |
|
Yep that should be there. |
`ThreadPlanStepOverRange::DoPlanExplainsStop` was moved to `ThreadPlanStepRange::DoPlanExplansStop` in 3dcce7c. This resulted in a merge conflict, which renamed this method instead of removing it.
@augusto2112 seems we ended up with an extra |
Looks correct to me! |
No description provided.