Skip to content

Commit 6be8aac

Browse files
authored
Merge pull request #11340 from jasonmolenda/cp/r158630250-qspeedtest-max-packet-size
[lldb][debugserver] Max response size for qSpeedTest (llvm#156099)
2 parents 80b8506 + 44993e6 commit 6be8aac

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

lldb/tools/debugserver/source/RNBRemote.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4422,12 +4422,12 @@ rnb_err_t RNBRemote::HandlePacket_qSpeedTest(const char *p) {
44224422
return HandlePacket_ILLFORMED(
44234423
__FILE__, __LINE__, p,
44244424
"Didn't find response_size value at right offset");
4425-
else if (*end == ';') {
4426-
static char g_data[4 * 1024 * 1024 + 16];
4427-
strcpy(g_data, "data:");
4428-
memset(g_data + 5, 'a', response_size);
4429-
g_data[response_size + 5] = '\0';
4430-
return SendPacket(g_data);
4425+
else if (*end == ';' && response_size < (4 * 1024 * 1024)) {
4426+
std::vector<char> buf(response_size + 6, 'a');
4427+
memcpy(buf.data(), "data:", 5);
4428+
buf[buf.size() - 1] = '\0';
4429+
rnb_err_t return_value = SendPacket(buf.data());
4430+
return return_value;
44314431
} else {
44324432
return SendErrorPacket("E79");
44334433
}

0 commit comments

Comments
 (0)