[Deserialization] Verify that the module that PM handles is valid.

This commit makes the pass manager verify the module that it needs to handle
before the transformations start. This verification only happens in debug mode.
The new assertion catches a few errors in our test suite. I filed rdar://23667534
and disabled the failing deserialization tests.

rdar://23667534

Author: nadavrot

lib/SILPasses/PassManager/PassManager.cpp

@@ -146,7 +146,13 @@ static void printModule(SILModule *Mod, bool EmitVerboseSIL) {
 
 SILPassManager::SILPassManager(SILModule *M, llvm::StringRef Stage) :
   Mod(M), StageName(Stage) {
-  
+
+#ifndef NDEBUG
+    // Check that the module that the pass manager is asked to process is
+    // valid.
+    Mod->verify();
+#endif
+
 #define ANALYSIS(NAME) \
   Analysis.push_back(create##NAME##Analysis(Mod));
 #include "swift/SILAnalysis/Analysis.def"

test/SIL/Serialization/deserialize_appkit.sil

@@ -5,4 +5,7 @@
 // REQUIRES: objc_interop
 // REQUIRES: OS=macosx
 
+// REQUIRES: rdar://23667534
+
+
 // CHECK-NOT: Unknown

test/SIL/Serialization/deserialize_coregraphics.swift

@@ -3,5 +3,6 @@
 // RUN: llvm-bcanalyzer %platform-sdk-overlay-dir/CoreGraphics.swiftmodule | FileCheck %s
 
 // REQUIRES: objc_interop
+// REQUIRES: rdar://23667534
 
 // CHECK-NOT: Unknown

test/SIL/Serialization/deserialize_darwin.sil

@@ -3,5 +3,6 @@
 // RUN: llvm-bcanalyzer %platform-sdk-overlay-dir/Darwin.swiftmodule | FileCheck %s
 
 // REQUIRES: objc_interop
+// REQUIRES: rdar://23667534
 
 // CHECK-NOT: Unknown

test/SIL/Serialization/deserialize_foundation.sil

@@ -3,5 +3,6 @@
 // RUN: llvm-bcanalyzer %platform-sdk-overlay-dir/Foundation.swiftmodule | FileCheck %s
 
 // REQUIRES: objc_interop
+// REQUIRES: rdar://23667534
 
 // CHECK-NOT: Unknown

test/SIL/Serialization/deserialize_objectivec.sil

@@ -3,5 +3,6 @@
 // RUN: llvm-bcanalyzer %platform-sdk-overlay-dir/ObjectiveC.swiftmodule | FileCheck %s
 
 // REQUIRES: objc_interop
+// REQUIRES: rdar://23667534
 
 // CHECK-NOT: Unknown