Skip to content

Add ControlPlaneRequest, ControlPlaneResponse #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 6, 2021

Conversation

fabianfett
Copy link
Member

Motivation:

In the coming weeks, we want to restructure the LambdaRuntime internals in such a way, that we allocate a lot less resources per invocation. To accomplish this, we want to encode and decode the ControlPlaneAPI requests directly from their semantic value. For this reason, we need a specialized ControlPlaneRequest and ControlPlaneResponse type that we can encode from and decode into.

Modifications:

  • Add ControlPlaneRequest, ControlPlaneResponse
  • Move Invocation and ErrorResponse into same file as ControlPlaneRequest
  • Remove Lambda namespace around Invocation

Result:

  • We can add encode methods for ControlPlaneRequest in a follow up PR
  • We can add decode methods for ControlPlaneResponse in a follow up PR

@fabianfett fabianfett added kind/enhancement Improvements to existing feature. 🔨 semver/patch No public API change. labels Dec 6, 2021
@fabianfett fabianfett requested a review from tomerd December 6, 2021 07:24
@fabianfett fabianfett merged commit b8d89ca into swift-server:main Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements to existing feature. 🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants