update and add examples to new APIs #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
force-pushed
the
update-example-and-tests
branch
5 times, most recently
from
9ef3ddb to
bb94234
Compare
|
What's the benefit of moving the String and Codable sample out of the main |
its much less noisy. these are really just samples and so they should not be part of the main package. One area where this causes headache is that tools that scan packages (like package collections and package indexes) and cannot tell that these modules are "not important" so they show up as valid modules you may want to use, which his not the intent |
stevapple
reviewed
Sep 23, 2021
| @@ -19,7 +19,6 @@ import NIO | |||
| // use this example which is more performant. | |||
| // `EventLoopLambdaHandler` does not offload the Lambda processing to a separate thread | |||
| // while the closure-based handlers do. | |||
There was a problem hiding this comment.
I think the description here should also be modified?
motivation: keep code up to date with API changes changes: * take advantage of @main where possible * move the top level Sample code to a new "Simple" examples subdirectory * add a sample that demonstrates how to test a lambda now that SwiftPM can test executables directly * update the test-sample docker setup to build & test th new samples * fix a few typos and In/Out typealias left overs
tomerd
force-pushed
the
update-example-and-tests
branch
from
bb94234 to
e861641
Compare
stevapple
reviewed
Sep 23, 2021
tomerd
force-pushed
the
update-example-and-tests
branch
from
e7c327f to
bd39461
Compare
Merged
fabianfett
approved these changes
Sep 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: keep code up to date with API changes
changes: