-
Notifications
You must be signed in to change notification settings - Fork 113
split events into spearate package #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. However we should have an "integration" test target in AWSLambdaEvents that ensures that the examples in the runtime still compile after a change in events.
@fabianfett you mean in the new "events" repo, so that changes there dont break the runtime? could they? |
The changes in there can't break the runtime, but the samples in the runtime repository, which would block CI. |
it may ben easier (from a CI point of view) to add an example we can CI there as well. WDYT? |
@tomerd Awesome! Now we should remove the |
motivation: the runtime library has a stabel API while the events are still moving target, so in order to provide a 1.0 stable version we should separate them out changes: * remove Events module * update readme * update Samples
done |
Failing nightly-main CI because of known issue in SwiftNIO: apple/swift-nio#1943 Not a blocker! Merging! |
motivation: the runtime library has a stabel API while the events are still moving target, so in order to provide a 1.0 stable version we should separate them out
changes: