Fixes AWS Event namespace problems #203
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
changed the title
fabianfett
force-pushed
the
ff-fix-event-namings
branch
2 times, most recently
from
1c36e24 to
9267050
Compare
tomerd
reviewed
Apr 21, 2021
|
@swift-server-bot test this please |
fabianfett
force-pushed
the
ff-fix-event-namings
branch
from
9267050 to
f26d701
Compare
|
@fabianfett is this read to merge? |
|
@tomerd Yes! |
tomerd
approved these changes
May 13, 2021
|
lets port this over to https://github.com/swift-server/swift-aws-lambda-events once after #216 is merged |
fabianfett
added a commit
to fabianfett/swift-aws-lambda-events
that referenced
this pull request
Aug 19, 2021
We have potential name clashes with existing AWS libraries, if we namespace our events under the service name. For example `S3.Event`. This problem has been documented here: swift-server/swift-aws-lambda-runtime#119 ### Changes This PR picks up the fix, that was initially intended to land in the runtime repo directly: swift-server/swift-aws-lambda-runtime#203
|
Will be fixed in the new events repo: swift-server/swift-aws-lambda-events#2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119.