fix shelcheck errors

Author: sebsto

Examples/_MyFirstFunction/clean.sh

@@ -1,7 +1,20 @@
-#!/bin/sh
+#!/bin/bash
+##===----------------------------------------------------------------------===##
+##
+## This source file is part of the SwiftAWSLambdaRuntime open source project
+##
+## Copyright (c) 2017-2024 Apple Inc. and the SwiftAWSLambdaRuntime project authors
+## Licensed under Apache License v2.0
+##
+## See LICENSE.txt for license information
+## See CONTRIBUTORS.txt for the list of SwiftAWSLambdaRuntime project authors
+##
+## SPDX-License-Identifier: Apache-2.0
+##
+##===----------------------------------------------------------------------===##
 
 echo "This script deletes the Lambda function and the IAM role created in the previous step and deletes the project files."
-read -p "Are you you sure you want to delete everything that was created? [y/n] " continue
+read -r -p "Are you you sure you want to delete everything that was created? [y/n] " continue
 if [[ ! $continue =~ ^[Yy]$ ]]; then
   echo "OK, try again later when you feel ready"
   exit 1

Examples/_MyFirstFunction/create_and_deploy_function.sh

@@ -1,4 +1,17 @@
-#!/bin/sh
+#!/bin/bash
+##===----------------------------------------------------------------------===##
+##
+## This source file is part of the SwiftAWSLambdaRuntime open source project
+##
+## Copyright (c) 2017-2024 Apple Inc. and the SwiftAWSLambdaRuntime project authors
+## Licensed under Apache License v2.0
+##
+## See LICENSE.txt for license information
+## See CONTRIBUTORS.txt for the list of SwiftAWSLambdaRuntime project authors
+##
+## SPDX-License-Identifier: Apache-2.0
+##
+##===----------------------------------------------------------------------===##
 
 # Stop the script execution if an error occurs 
 set -e -o pipefail
@@ -19,7 +32,7 @@ You must have an AWS account and know an AWS access key, secret access key, and
 These values are read from '~/.aws/credentials'.
 "
 
-read -p "Are you ready to create your first Lambda function in Swift? [y/n] " continue
+read -r -p "Are you ready to create your first Lambda function in Swift? [y/n] " continue
 if [[ ! $continue =~ ^[Yy]$ ]]; then
   echo "OK, try again later when you feel ready"
   exit 1
@@ -84,7 +97,8 @@ echo "🚀 Deploy to AWS Lambda"
 
 # retrieve your AWS Account ID 
 echo "🔑 Retrieve your AWS Account ID"
-export AWS_ACCOUNT_ID=$(aws sts get-caller-identity --query Account --output text)
+AWS_ACCOUNT_ID=$(aws sts get-caller-identity --query Account --output text)
+export AWS_ACCOUNT_ID
 
 # Check if the role already exists
 echo "🔍 Check if a Lambda execution IAM role already exists"
@@ -97,8 +111,8 @@ aws lambda create-function \
 --zip-file fileb://.build/plugins/AWSLambdaPackager/outputs/AWSLambdaPackager/MyLambda/MyLambda.zip \
 --runtime provided.al2 \
 --handler provided  \
---architectures $(uname -m) \
---role arn:aws:iam::${AWS_ACCOUNT_ID}:role/lambda_basic_execution > /dev/null 2>&1
+--architectures "$(uname -m)" \
+--role arn:aws:iam::"${AWS_ACCOUNT_ID}":role/lambda_basic_execution > /dev/null 2>&1
 
 echo "⏰ Waiting 10 secs for the Lambda function to be ready..."
 sleep 10

Examples/_MyFirstFunction/create_iam_role.sh

@@ -1,3 +1,18 @@
+#!/bin/bash
+##===----------------------------------------------------------------------===##
+##
+## This source file is part of the SwiftAWSLambdaRuntime open source project
+##
+## Copyright (c) 2017-2024 Apple Inc. and the SwiftAWSLambdaRuntime project authors
+## Licensed under Apache License v2.0
+##
+## See LICENSE.txt for license information
+## See CONTRIBUTORS.txt for the list of SwiftAWSLambdaRuntime project authors
+##
+## SPDX-License-Identifier: Apache-2.0
+##
+##===----------------------------------------------------------------------===##
+
 #
 # Create an IAM role for the Lambda function
 #
@@ -23,14 +38,14 @@ EOF
     # Create the IAM role
     echo "🔐 Create the IAM role for the Lambda function"
     aws iam create-role \
-    --role-name $role_name \
+    --role-name "${role_name}" \
     --assume-role-policy-document file://trust-policy.json > /dev/null 2>&1
 
     # Attach basic permissions to the role
     # The AWSLambdaBasicExecutionRole policy grants permissions to write logs to CloudWatch Logs
     echo "🔒 Attach basic permissions to the role"
     aws iam attach-role-policy \
-    --role-name $role_name \
+    --role-name "${role_name}" \
     --policy-arn arn:aws:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole > /dev/null 2>&1
 
     echo "⏰ Waiting 10 secs for IAM role to propagate..."