Skip to content

Set minimum swift-collections version to 1.1.0 📦 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

slashmo
Copy link
Member

@slashmo slashmo commented Jul 14, 2024

We rely on OrderedDictionary from apple/swift-collections to conform to Sendable, but this conformance was only added in Swift Collections 1.1.0. Previously, the minimum version we depended on was 1.0.0, potentially leading to issues where users would still pull in a swift-collections version without Sendable conformances. To mitigate this, we now increased the minimum version to 1.1.0.

@slashmo slashmo enabled auto-merge (squash) July 14, 2024 13:20
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.50%. Comparing base (9a15962) to head (b5b0c25).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files           6        6           
  Lines         402      402           
=======================================
  Hits          400      400           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slashmo slashmo merged commit aeeea07 into main Jul 14, 2024
8 checks passed
@slashmo slashmo deleted the fix/swift-collections-dependency branch July 14, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants