Skip to content

Conversation

@slashmo
Copy link
Member

@slashmo slashmo commented May 24, 2025

This PR runs the code generator on v1.34.0.


Deprecated struct

The code generator required a small change to accommodate the schema update for deprecations, which I also included here. This PR includes the bare minimum to successfully run the generator again, but there may be more improvements we could make based on the new format, e.g. @deprecated(renamed:...) annotations for automatic fix-its.

See also: open-telemetry/semantic-conventions#2047

@slashmo slashmo requested a review from a team as a code owner May 24, 2025 23:58
@slashmo
Copy link
Member Author

slashmo commented May 25, 2025

@NeedleInAJayStack Whenever you find the time, I'd greatly appreciate it if you could take a look at the generator changes I had to make in this PR 🙏

@NeedleInAJayStack
Copy link
Contributor

This PR includes the bare minimum to successfully run the generator again, but there may be more improvements we could make based on the new format, e.g. @deprecated(renamed:...) annotations for automatic fix-its.

The generator changes look great to me!

As you said, there's likely more we could do with their new deprecation format. Here's the expected deprecated formatting from the Rust open-telemetry/weaver tool, which is a pretty good authority. I've created an issue for this here: #15

@slashmo
Copy link
Member Author

slashmo commented May 25, 2025

@NeedleInAJayStack Thanks for the review 🙏 Would you like to take on any of the spin-off issues from this PR (#15, #16)?

@slashmo slashmo merged commit a59d491 into main May 25, 2025
3 checks passed
@slashmo slashmo deleted the v1.34.0 branch May 25, 2025 08:52
@NeedleInAJayStack
Copy link
Contributor

@NeedleInAJayStack Thanks for the review 🙏 Would you like to take on any of the spin-off issues from this PR (#15, #16)?

Sure, I'd be happy to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants