do not include target to product-target map if its build config is missing

Author: Ilushkanama

lib/build/product_extractor.rb

@@ -48,7 +48,7 @@ def list_products(built_node)
         elsif built_node.has_acceptable_product?
           list_single_product(built_node)
         else
-          raise Informative, "#{built_node.name} has unsupported product type: #{built_node.native_target.product_type}"
+          raise XcodeArchiveCache::Informative, "#{built_node.name} has unsupported product type: #{built_node.native_target.product_type}"
         end
       end
 
@@ -60,7 +60,7 @@ def list_framework_products(built_node)
         framework_glob = get_main_product_glob(built_node)
         framework_path = Dir.glob(framework_glob).first
         unless framework_path
-          raise Informative, "Framework product not found for #{built_node.name}"
+          raise XcodeArchiveCache::Informative, "Framework product not found for #{built_node.name}"
         end
 
         framework_dsym_glob = File.join(File.dirname(framework_glob), built_node.dsym_file_name)
@@ -79,7 +79,7 @@ def list_single_product(built_node)
         product_glob = get_main_product_glob(built_node)
         product_path = Dir.glob(product_glob).first
         unless product_path
-          raise Informative, "Product of type #{built_node.native_target.product_type} not found for #{built_node.name}"
+          raise XcodeArchiveCache::Informative, "Product of type #{built_node.native_target.product_type} not found for #{built_node.name}"
         end
 
         paths = [product_path]
@@ -181,7 +181,7 @@ def list_framework_bc_symbolmaps(framework_path)
         executable_name = File.basename(framework_path, File.extname(framework_path))
         executable_path = File.join(framework_path, executable_name)
         unless File.exist?(executable_path)
-          raise Informative, "Failed to find executable inside framework: #{framework_path}"
+          raise XcodeArchiveCache::Informative, "Failed to find executable inside framework: #{framework_path}"
         end
 
         uuids = list_bc_symbolmap_uuids(executable_path)

lib/build_graph/builder.rb

@@ -61,7 +61,7 @@ def add_to_graph(target, graph, is_root, target_stack = [])
         display_name = target.display_name
         if target_stack.include?(display_name)
           target_stack.push(display_name)
-          raise Informative, "Circular dependency detected: #{target_stack.join(" -> ")}"
+          raise XcodeArchiveCache::Informative, "Circular dependency detected: #{target_stack.join(" -> ")}"
         end
 
         node = ALL_NODES.select {|node| node.native_target.uuid == target.uuid && node.native_target.project == target.project}.first
@@ -141,7 +141,7 @@ def get_settings(target)
         info("getting settings for #{target.display_name}")
         build_settings = build_settings_loader.get_settings(target.project.path, target.display_name)
         unless build_settings
-          raise Informative, "No build settings loaded for #{target.display_name}"
+          raise XcodeArchiveCache::Informative, "No build settings loaded for #{target.display_name}"
         end
 
         build_settings

lib/build_graph/native_target_finder.rb

@@ -102,15 +102,15 @@ def find_for_file(file)
           end
 
           if target == nil
-            raise Informative, "Target for #{file.file_ref.path} not found"
+            raise XcodeArchiveCache::Informative, "Target for #{file.file_ref.path} not found"
           end
 
           target
         elsif file.file_ref.is_a?(Xcodeproj::Project::Object::PBXFileReference)
           # products of sibling project targets are added as PBXFileReferences
           targets = find_with_product_path(file.file_ref.path)
           if targets.length > 1
-            raise Informative, "Found more than one target with product #{File.basename(file.file_ref.path)} in:\n#{targets.map(&:project)}"
+            raise XcodeArchiveCache::Informative, "Found more than one target with product #{File.basename(file.file_ref.path)} in:\n#{targets.map(&:project)}"
           end
 
           targets.first
@@ -149,7 +149,9 @@ def setup_product_name_to_target_mapping
         @product_name_to_target = Hash.new
 
         @all_targets.each do |target|
-          build_settings = target.find_build_configuration(build_configuration_name).build_settings
+          build_settings = target.find_build_configuration(build_configuration_name, raise_if_not_found: false)&.build_settings
+          next unless build_settings
+
           full_settings = build_settings
           full_settings[XcodeArchiveCache::BuildSettings::TARGET_NAME_KEY] = target.name
           product_name = @interpolator.interpolate(build_settings[XcodeArchiveCache::BuildSettings::PRODUCT_NAME_KEY], full_settings)

lib/config/config.rb

@@ -52,7 +52,7 @@ def file_path
       def active_configuration
         configuration = configurations.select{|config| config.name == active_configuration_name }.first
         if configuration == nil
-          raise Informative, "Found no configuration with name \"#{active_configuration_name}\""
+          raise XcodeArchiveCache::Informative, "Found no configuration with name \"#{active_configuration_name}\""
         end
 
         configuration
@@ -172,7 +172,7 @@ def self.from_file(path)
         begin
           eval(contents, nil, path)
         rescue Exception => e
-          raise Informative, "Invalid #{File.basename(path)} file: #{e.message}"
+          raise XcodeArchiveCache::Informative, "Invalid #{File.basename(path)} file: #{e.message}"
         end
       end
 

lib/extensions/target.rb

@@ -11,12 +11,12 @@ module BuildConfigurationSearch
   #
   # @return [Xcodeproj::Project::Object::XCBuildConfiguration]
   #
-  def find_build_configuration(configuration_name)
+  def find_build_configuration(configuration_name, raise_if_not_found: true)
     build_configuration = build_configurations
                             .select { |configuration| configuration.name == configuration_name }
                             .first
-    unless build_configuration
-      raise Informative, "#{configuration_name} build configuration not found on target #{display_name}"
+    if raise_if_not_found && build_configuration == nil
+      raise XcodeArchiveCache::Informative, "#{configuration_name} build configuration not found on target #{display_name} #{project.path}"
     end
 
     build_configuration

lib/injection/injector.rb

@@ -175,7 +175,7 @@ def add_as_prebuilt_dependency(prebuilt_node, dependent_target)
         debug("adding #{prebuilt_node.name} as prebuilt to #{dependent_target.display_name}")
 
         unless prebuilt_node.has_acceptable_product?
-          raise Informative, "#{prebuilt_node.name} has unsupported product type: #{prebuilt_node.native_target.product_type}"
+          raise XcodeArchiveCache::Informative, "#{prebuilt_node.name} has unsupported product type: #{prebuilt_node.native_target.product_type}"
         end
 
         if prebuilt_node.has_framework_product?

lib/injection/pods_xcframework_fixer.rb

@@ -30,7 +30,7 @@ def fix(target, build_settings_loader)
           fix_file(script_path)
 
           unless shell_executor.execute_with_env(script_path, build_settings.all)
-            raise Informative, "Failed to execute Pods XCFramework script #{script_path}"
+            raise XcodeArchiveCache::Informative, "Failed to execute Pods XCFramework script #{script_path}"
           end
         end
 

lib/runner/runner.rb

@@ -37,7 +37,7 @@ def list_projects
         return workspace.file_references.map {|file_reference| Xcodeproj::Project.open(file_reference.absolute_path(workspace_dir))}
       end
 
-      raise Informative, "Configuration misses entry point -- must have either a project or a workspace"
+      raise XcodeArchiveCache::Informative, "Configuration misses entry point -- must have either a project or a workspace"
     end
 
     def run
@@ -65,7 +65,7 @@ def perform_cleanup
     def handle_target(target_config)
       target = @native_target_finder.find_for_product_name(target_config.name)
       unless target
-        raise Informative, "Target not found for #{target_config.name}"
+        raise XcodeArchiveCache::Informative, "Target not found for #{target_config.name}"
       end
 
       xcodebuild_executor = XcodeArchiveCache::Xcodebuild::Executor.new(config.active_configuration.build_configuration,
@@ -111,7 +111,7 @@ def handle_target(target_config)
     def find_dependency_target(target, dependency_name)
       dependency_target = @native_target_finder.find_for_product_name(dependency_name)
       unless dependency_target
-        raise Informative, "Target not found for #{dependency_name} of #{target.display_name}"
+        raise XcodeArchiveCache::Informative, "Target not found for #{dependency_name} of #{target.display_name}"
       end
 
       dependency_target

lib/shell/executor.rb

@@ -12,7 +12,7 @@ def execute_for_output(command, print_command = false)
         output, status = Open3.capture2e(actual_command)
 
         if status.exitstatus != 0
-          raise Informative, "#{command}\nexecution failed\n#{output}"
+          raise XcodeArchiveCache::Informative, "#{command}\nexecution failed\n#{output}"
         end
 
         output

lib/xcodebuild/executor.rb

@@ -117,7 +117,7 @@ def destination_flag
         #
         inferred_destination = action == ARCHIVE_ACTION ? GENERIC_DESTINATION : destination_by_platform
         if inferred_destination == nil
-          raise Informative, "Destination not set for #{platform} platform"
+          raise XcodeArchiveCache::Informative, "Destination not set for #{platform} platform"
         end
 
         destination_specifier = inferred_destination == GENERIC_DESTINATION ? "generic/platform=#{platform}" : inferred_destination